Refactor ConfigurationContentReader #30139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TeslaCN
approved these changes
Feb 16, 2024
Comment on lines
+42
to
+44
| @SneakyThrows(URISyntaxException.class) | ||
| private File getResourceFile(final String configurationSubject) { | ||
| return new File(Objects.requireNonNull(Thread.currentThread().getContextClassLoader().getResource(configurationSubject)).toURI().getPath()); |
There was a problem hiding this comment.
- Is it possible to avoid creating a
java.io.Fileinstance by returning ajava.nio.file.Pathinstance directly? Creating ajava.io.Fileinstance under GraalVM Native Image will cause it to get the wrongjava.nio.file.Path, thus breaking GraalVM Native Image integration. Reference Make JDBCRepositorySQLLoader avoid usingPath#toFilein GraalVM Native Image #29014 and Open theresource:/related FileSystem for JDBCRepositorySQLLoader in the GraalVM Native Image environment #29009.
Caused by: java.nio.file.NoSuchFileException: /test-native/yaml/modes/cluster/zookeeper.yaml
at [email protected]/sun.nio.fs.UnixFileSystemProvider.newByteChannel(UnixFileSystemProvider.java:261)
at [email protected]/java.nio.file.Files.newByteChannel(Files.java:379)
at [email protected]/java.nio.file.Files.newByteChannel(Files.java:431)
at [email protected]/java.nio.file.spi.FileSystemProvider.newInputStream(FileSystemProvider.java:420)
at [email protected]/java.nio.file.Files.newInputStream(Files.java:159)
at [email protected]/java.nio.file.Files.newBufferedReader(Files.java:2897)
at [email protected]/java.nio.file.Files.readAllLines(Files.java:3392)
at [email protected]/java.nio.file.Files.readAllLines(Files.java:3433)
at org.apache.shardingsphere.driver.jdbc.core.driver.url.type.ClassPathURLLoader.load(ClassPathURLLoader.java:39)
at org.apache.shardingsphere.driver.jdbc.core.driver.url.ShardingSphereURLLoadEngine.loadContent(ShardingSphereURLLoadEngine.java:47)
at org.apache.shardingsphere.driver.jdbc.core.driver.DriverDataSourceCache.createDataSource(DriverDataSourceCache.java:55)
... 77 common frames omitted
There was a problem hiding this comment.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.